On Wed, Feb 03, 2016 at 03:12:27PM +0100, Uros Bizjak wrote: > On Wed, Feb 3, 2016 at 2:59 PM, Jakub Jelinek <ja...@redhat.com> wrote: > > On Wed, Feb 03, 2016 at 02:53:56PM +0100, Uros Bizjak wrote: > >> diff --git a/gcc/testsuite/lib/asan-dg.exp b/gcc/testsuite/lib/asan-dg.exp > >> index 994160e..a1198c0 100644 > >> --- a/gcc/testsuite/lib/asan-dg.exp > >> +++ b/gcc/testsuite/lib/asan-dg.exp > >> @@ -20,7 +20,7 @@ > >> proc check_effective_target_fsanitize_address {} { > >> return [check_no_compiler_messages fsanitize_address executable { > >> int main (void) { return 0; } > >> - } "-fsanitize=address"] > >> + }] > >> } > >> > > > > This is just weird. What if fsanitize_address effective target is used > > outside of asan/ (i.e. without asan_init first) ? > > It won't work, you also need various link flags that are part of > TEST_ALWAYS_FLAGS.
The patch is ok then. Jakub