On 01/29/2016 10:57 PM, David Malcolm wrote:
On Fri, 2016-01-29 at 20:50 +0100, Jakub Jelinek wrote:
Hi!
This patch reverts one tiny change from r228049 changes (which hasn't
been
mentioned in the ChangeLog or patch description). We definitely need
to
revisit this for GCC 7, but stage4 is probably not the right time for
that,
and the patch fixes e.g. tons of warnings (or with -Werror errors on
including pretty much all glib2 headers).
Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
2016-01-29 Jakub Jelinek <ja...@redhat.com>
PR preprocessor/69543
PR c/69558
* c-pragma.c (handle_pragma_diagnostic): Pass input_location
instead of loc to control_warning_option.
* gcc.dg/pr69543.c: New test.
* gcc.dg/pr69558.c: New test.
This touches c-family; shouldn't the new tests be in c-c++-common,
rather than gcc.dg? (presumably we need to ensure that the glib2
headers are sane from C++ also)
I've been attempting to fix these by fixing linemap_compare_locations,
but I don't have that approach working, so fwiw I don't object to this
patch.
Then let's go ahead with this patch. If you come up with something
cleaner with the linemap_compare_locations, then we can revert the
c-pragma part of this change (keeping the tests, of course).
jeff