This patch by Chris Manghane fixes the Go frontend to not crash on an
invalid array type declaration that is not otherwise used. This fixes
https://golang.org/issue/12937. Bootstrapped and ran Go testsuite on
x86_64-pc-linux-gnu. Committed to mainline.
Ian
Index: gcc/go/gofrontend/MERGE
===================================================================
--- gcc/go/gofrontend/MERGE (revision 232855)
+++ gcc/go/gofrontend/MERGE (working copy)
@@ -1,4 +1,4 @@
-731941c155214d6158fa800e52ab3225c0b55f73
+721c778adb8f99d8a6b7795dbad86013ccc9ba91
The first line of this file holds the git revision number of the last
merge done from the gofrontend repository.
Index: gcc/go/gofrontend/gogo.cc
===================================================================
--- gcc/go/gofrontend/gogo.cc (revision 232239)
+++ gcc/go/gofrontend/gogo.cc (working copy)
@@ -2699,6 +2699,15 @@ Gogo::lower_parse_tree()
{
Lower_parse_tree lower_parse_tree(this, NULL);
this->traverse(&lower_parse_tree);
+
+ // There might be type definitions that involve expressions such as the
+ // array length. Make sure to lower these expressions as well. Otherwise,
+ // errors hidden within a type can introduce unexpected errors into later
+ // passes.
+ for (std::vector<Type*>::iterator p = this->verify_types_.begin();
+ p != this->verify_types_.end();
+ ++p)
+ Type::traverse(*p, &lower_parse_tree);
}
// Lower a block.
