Hi! On Thu, 10 Dec 2015 18:51:48 +0100, Martin Jambor <[email protected]> wrote: > On Mon, Dec 07, 2015 at 12:46:45PM +0100, Jakub Jelinek wrote: > > On Mon, Dec 07, 2015 at 12:17:58PM +0100, Martin Jambor wrote: > > > [...] There are no failing > > > testcases if HSA is not configured. If it is, there are some, all of > > > which fall into one the following categories: > > > > > > 1) HSA cannot compile a function for one reason or another (most > > > common cause is inability of HSA to take an address of a function > > > or make an indirect call) and gives a warning, which is regarded > > > as an "excess error" by dejagnu.
Confirmed:
[...]/gcc/testsuite/c-c++-common/gomp/clauses-1.c: In function
'bar._omp_fn.26.hsa.31':
cc1: warning: could not emit HSAIL for the function [-Whsa]
cc1: note: support for HSA does not implement non-gridified OpenMP parallel
constructs.
[...]
..., and many more. So, with --enable-offload-targets=[...],hsa we
regress (PASS -> FAIL; "test for excess errors") such compile tests.
> > It would be good if there is a -W* switch to turn such warnings off.
> > Not just for the purposes of dejagnu libgomp testing, but say one
> > might try to compile a program primarily say for XeonPhi or PTX offloading,
> > but have HSA enabled to, but care primarily about the former two, etc.
>
> All these warnings are in the -Whsa group and can be suppressed with
> -Wno-hsa.
These compile tests are done without any -W* flags; -Whsa is enabled by
default. How to address this mismatch? Put -Wno-has into all regressing
test case files individually? Run the affected testsuites with -Wno-hsa?
Not enable -Whsa by default (but I agree it's useful to users)?
(Instead, enable with -Wall, which any sane user should be specifying?)
A very similar problem also exists for nvptx offloading (Nathan CCed),
where we emit similar warnings (enabled by default). As nvptx offloading
happens during link-time (not compile-time, as with hsa offloading),
these don't affect GCC's compile tests, but need to be worked around in
libgomp test cases.
Grüße
Thomas
signature.asc
Description: PGP signature
