On 01/21/2016 03:05 AM, Andreas Krebbel wrote:
On 01/02/2016 08:16 PM, Marcin Kościelnicki wrote:
When an unconditional jump with side effects targets an immediately
following label, rtl_tidy_fallthru_edge is called. Since it has side
effects, it doesn't remove the jump, but the label is still marked
as fallthru. This later causes a verification error. Do nothing in this
case instead.
gcc/ChangeLog:
* cfgrtl.c (rtl_tidy_fallthru_edge): Bail for unconditional jumps
with side effects.
The change looks ok to me (although I'm not able to approve it). Could you
please run regressions
tests on x86_64 with that change?
Perhaps a short comment in the code would be good.
I think the patch is technically fine, the question is does it fix a
visible bug? I read the series as new feature enablement so I put this
patch into my gcc7 queue.
jeff
