Hi Tobi,

The patch looks good modulo some formatting changes:

+    free(c->free_name);
+  int length = strlen(e->name);
[...]

Please follow the GNU style: there should be a space between the
function name and the open parenthesis.

-      dom = new_Cloog_Domain_from_ppl_Pointset_Powerset (PBB_DOMAIN (pbb),
+      domain = new_Cloog_Domain_from_ppl_Pointset_Powerset (PBB_DOMAIN (pbb),
                                                          scop_nb_params (scop),
                                                          cloog_state);

You would still need proper indentation on the last two lines.

+  /* Dump a .cloog input file, if requested.  This feature is only
+   * enabled in the Graphite branch.  */

Please remove the * from the beginning of the new line in this comment.

Ok with these changes and after the other patches are committed.

Thanks,
Sebastian

Reply via email to