On 30.11.15 17:22, Jakub Jelinek wrote:
On Mon, Nov 30, 2015 at 05:17:29PM +0100, Bernd Schmidt wrote:
On 11/30/2015 01:12 PM, Andreas Tobler wrote:
On 30.11.15 11:28, Bernd Schmidt wrote:
On 11/29/2015 08:32 PM, Andreas Tobler wrote:
-/* { dg-do run { target { *-*-linux* } } } */
+/* { dg-do run { target { *-*-linux* *-*-freebsd* } } } */
I see a patch from you to add asan support to x86 freebsd, but what
about other architectures?
You mean because of the wildcard? I'll add them as I have time to port
them.
For now they are UNSUPPORTED.
Is that how they show up, or do you get FAILs on other FreeBSDs?
This is inside of asan.exp, which is guarded with
check_effective_target_fsanitize_address
and therefore should not be run at all on non-asan targets.
It manifests this way:
/usr/local/bin/ld: cannot find libasan_preinit.o: No such file or directory
/usr/local/bin/ld: cannot find -lasan
collect2: error: ld returned 1 exit status
Then it bails out and the asan tests are skipped.
...
testsuite/gcc.dg/asan/asan.exp completed in 1 seconds
...
There is no UNSUPPORTED in the log file.
I think the testsuite changes are fine, but it IMHO doesn't make sense to
commit it until the FreeBSD asan supports lands in (which is dependent on
the upstream libsanitizer change I believe). Once it happens, it can be
cherry-picked from there, the config/i386 part looks reasonable.
I agree that it doesn't make much sense to commit for the public, but
I'd have a patch less on the table ;)
But, np problem at all.
This is the cherry I'd like to pick once it has landed :)
http://reviews.llvm.org/D15049
The part for lib/asan/asan_linux.cc.
Thanks for the comments!
Andreas
