On Fri, Aug 5, 2011 at 13:37, Tom Tromey <tro...@redhat.com> wrote:
>>>>>> "Gabriel" == Gabriel Charette <gch...@google.com> writes:
>
> Gabriel> This hack, has described in more details in the email labeled
> Gabriel> "Line 0 Hack??", was now causing problem when serializing the
> Gabriel> line_table in pph.
>
> I think you do have to handle location 0 somehow.
> This is UNKNOWN_LOCATION, referred to widely in the sources.
>
> Gabriel> 2011-08-01  Gabriel Charette  <gch...@google.com>
> Gabriel>        * decl.c (finish_function): Remove unecessary line 0 hack.
>
> Now that -Wunreachable-code is gone, I doubt this code is even
> theoretically relevant.  So, while I can't approve or reject this patch,
> it seems reasonable to me.

In that case, this is OK for trunk.  Thanks Tom.


Diego.

Reply via email to