Re: [PATCH][calls.c] PR rtl-optimization/67226: Take into account pretend_args_size when checking stack offsets for sibcall optimisation

[Bernd Schmidt]

On 11/25/2015 03:10 PM, Kyrill Tkachov wrote:

What should we do when we don't have STACK_GROWS_DOWNWARD? Do we need to
write:
if (STACK_GROWS_DOWNWARD)
   i -= crtl->args.pretend_args_size;
else
   i += crtl->args.pretend_args_size;

I think so. I mean, this should mirror this code here, right?

      /* The argument block when performing a sibling call is the
         incoming argument block.  */
      if (pass == 0)
        {
          argblock = crtl->args.internal_arg_pointer;
          if (STACK_GROWS_DOWNWARD)
            argblock
              = plus_constant (Pmode, argblock, crtl->args.pretend_args_size);
          else
            argblock
              = plus_constant (Pmode, argblock, -crtl->args.pretend_args_size);


Bernd