Martin, thanks for getting this patch out. I like the patch. Jeff, clang-format has scripts that allow formatting only the lines touched by a patch. It also has a script to integrate with git: https://llvm.org/svn/llvm-project/cfe/trunk/tools/clang-format/git-clang-format We could use those scripts in a commit hook to automatically enforce correct formatting of new patches.
Sebastian On Wed, Nov 18, 2015 at 8:10 AM, Martin Liška <mli...@suse.cz> wrote: > Hello. > > Following patch adds a clang-format config file that should respect the GNU > coding standards. > As the file is not part of build process, I hope the patch can be applied > even though > we've just skipped to stage3? The patch adds a hunk to Makefile which can > create symlink > to the root directory of the GCC compiler. The clang-format automatically > loads style from > the configuration file. > > clang-format (version 3.8) provides rich variety of configuration options > that can > ensure the GNU coding style. > > Limitations: > + placement of opening brace of an initializer can't be requested > + sometimes, '(' is the trailing symbol at the end of a line, which can look > weird > > As we've been continuously converting our source base to C++, the > clang-format should > provide better results than a collection of regular expressions > (check_GNU_style.sh). > > As a reference file I attach gcc/tree-ssa-uninit.c file. > Feel free to comment the suggested configuration file. > > Thanks, > Martin >