On 11/13/2015 05:02 PM, Wilco Dijkstra wrote:
* gcc/ccmp.c (expand_ccmp_expr): Extract cmp_code from return value
of
expand_ccmp_expr_1.
I was trying to review this part of the patch in isolation and got very
confused because the patch also changes the return values of the ccmp
target hooks, but does not update the documentation.
In this file, return values are also underdocumented in function comments.
Also,
> + enum rtx_code cmp_code = GET_CODE (tmp);
Lose the "enum". Elsewhere in the patch too.
Other than that this part is probably fine (leaving the aarch64 part to
the appropriate maintainers), but please resubmit with these issues fixed.
Bernd
