On Tue, Nov 17, 2015 at 12:23:51PM -0500, Nathan Sidwell wrote:
> On 11/17/15 12:23, Nathan Sidwell wrote:
> >On 11/17/15 12:16, Cesar Philippidis wrote:
> >>This patch adds an empty priority_queues.c in libgomp for nvptx targets.
> >>Nvptx targets don't have sufficient support for a complete libgomp
> >>library, so we're only building a subset of it. And without that empty
> >>file, I was seeing an error message that looked like this:
> >>
> >>libgomp/libgomp.h:122:17: fatal error: sem.h: No such file or directory
> >> #include "sem.h"
> >>
> >>I'm still running the entire testsuite, but it doesn't introduce any new
> >>regressions in libgomp.oacc-c. Is this OK for trunk, or am I missing
> >>something?
> >
> >Please apply to trunk. I've just tripped over it, you've saved me an
> >investigation ...
>
> Actually, please put a comment in the file, rather than leave it empty
Yeah, something like
/* Intentionally empty. */
or similar is better than empty file.
Jakub
