On 11/12/2015 07:40 PM, Jan Hubicka wrote:
>>>> +
>>>> + /* Initialize hash values if we are not in LTO mode. */
>>>> + if (!in_lto_p)
>>>> + item->get_hash ();
>>>> }
>>>
>>> Hmm, what is the difference to the LTO mode here. I would have expected
>>> that all the items
>>> was analyzed in both paths?
>>
>> Difference is that in case of the LTO mode, the hash value is read from
>> streamed LTO file.
>> On the other hand, in classic compilation mode we have to force the
>> calculation as a hash value
>> is computed lazily.
>
> In this case we need to also handle cases where function/variable is born
> during WPA (i.e. produced
> by earlier pass), so in_lto_p check looks wrong.
> I will look at the updated patch.
>
> Honza
>
Hi Honza.
Currently we just register {cgraph,varpool}_removal_hooks in WPA.
Probably place for enhancement?
Thanks,
Martin
