On Tue, Nov 10, 2015 at 09:12:55AM -0500, Nathan Sidwell wrote:
> +                 /* Create a local object to hold the instance
> +                    value.  */
> +                 tree inst = create_tmp_var
> +                   (TREE_TYPE (TREE_TYPE (new_var)),
> +                    IDENTIFIER_POINTER (DECL_NAME (new_var)));
Can you please rewrite this as:
                    tree type = TREE_TYPE (TREE_TYPE (new_var));
                    tree n = DECL_NAME (new_var);
                    tree inst = create_tmp_var (type, IDENTIFIER_POINTER (n));
or so (perhaps
                    const char *name
                      = IDENTIFIER_POINTER (DECL_NAME (new_var));
instead but then it takes one more line)?
I really don't like line breaks before opening ( unless really
necessary.

Otherwise LGTM.

        Jakub

Reply via email to