On Fri, Nov 06, 2015 at 03:00:30PM +0100, Bernd Schmidt wrote:
> >Sanity-checked by running the libgomp testsuite. I realize the #ifdef in
> >internal-fn.c is not appropriate: it's there to make the patch smaller, I'll
> >replace it with a target hook if otherwise this approach is ok.
>
> FWIW, no objections from me regarding the approach.
As I said on IRC, I fear it is not a general solution, and will try to write
a testcase that demonstrates that soon.
That said, as a temporary partial workaround it might be acceptable, but
1) there really should be a target hook
2) it should never be emitted when not in target regions (declare target
functions or when inside of OpenMP target region)
3) it should be folded away as soon as possible for the non-PTX
targets (both host and say XeonPhi), so in the openacc pass shortly post
IPA (or look at if something that will come with the HSA merge could help
there)
Jakub
