On Thu, Oct 29, 2015 at 09:02:22AM -0500, Segher Boessenkool wrote:
> Hi!
>
> On Tue, Oct 27, 2015 at 06:31:41PM -0400, Michael Meissner wrote:
> > Index: gcc/testsuite/gcc.target/powerpc/float128-1.c
> > ===================================================================
> > --- gcc/testsuite/gcc.target/powerpc/float128-1.c (revision 0)
> > +++ gcc/testsuite/gcc.target/powerpc/float128-1.c (revision 0)
> > @@ -0,0 +1,149 @@
> > +/* { dg-do run { target { powerpc*-*-linux* } } } */
> > +/* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */
> > +/* { dg-skip-if "" { powerpc*-*-*spe* } { "*" } { "" } } */
>
> Some of this is redundant. Should this really be linux-only?
> The second line doesn't do anything then. { "*" } { "" } isn't
> needed either.
>
> In general, please only add dg-skip-if if you know it is needed.
>
> There probably should be an effective-target for float128.
Well the normal VSX target should work.
Back when I was doing power7 development, there were problems with Darwin
and/or SPE ignoring the -mcpu=<xxx> option, so I've just cloned the code on
these tests ever since.
--
Michael Meissner, IBM
IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA
email: [email protected], phone: +1 (978) 899-4797
