On 29 October 2015 at 11:07, Ramana Radhakrishnan <ramana....@googlemail.com> wrote: > On Thu, Oct 29, 2015 at 9:25 AM, Christophe Lyon > <christophe.l...@linaro.org> wrote: >> Hi, >> >> On arm*-*-eabi*, arm*-*-symbianelf*, arm*-*-rtems* targets, >> crtfastmath.o is not part of $extra_parts, which means that it is not >> built, even though the make build rule is present via the inclusion of >> t-crtfm. >> >> The impact is that the link fails when using -ffast-math. >> >> The attached patch adds crtfastmath.o to $extra_parts, for >> arm*-*-eabi*, arm*-*-symbianelf*, arm*-*-rtems* targets. >> >> I tested on arm-none-eabi, and I am not sure if this is correct for >> symbian/rtems. >> >> OK? Or should I restrict the change to arm*-*-eabi* ? > > > I don't see how they are inappropriate on those targets as > crtfastmath.c only set flush to zero in with -ffast-math when the > target architecture has floating point hardware and are only brought > in if the link spec asks for it (which it does only with -ffast-math) > > Ok if no regressions. Now committed. For the record, I see +2500 PASS on arm-none-eabi.
Christophe. > > regards > Ramana > >> >> Thanks, >> >> Christophe.