On Thu, 17 Sep 2015, Mark Wielaard wrote:
>>> I believe making -Wunused-const-variable part of -Wall is not
>>> a good idea.
>>>
>>> For example, I have a nightly build of Wine with a nightly build
>>> of GCC. And my notifaction mail went from twently lines of warning
>>> to 6500 -- all coming from header files.
> I was just taking a look. They come from constructs like:
>
> static const WCHAR INSTALLPROPERTY_VERSIONSTRINGW[] =
> {'V','e','r','s','i','o','n','S','t','r','i','n','g',0};
>
> Using the more idiomatic and a bit more readable:
>
> #define INSTALLPROPERTY_VERSIONSTRINGW u"VersionString"
>
> gets rid of most of the issues.
I am working to get Wine converted to at least the u"VersionString"
flavor, and then ideally to use #define or to disable this new
warning globally.
Should there remain any other cases, I'll report them here.
(Thanks for the hints, Mark!)
Gerald
