On Thu, Oct 22, 2015 at 04:28:17PM +0200, Bernd Schmidt wrote:
> On 10/22/2015 04:24 PM, Nathan Sidwell wrote:
> >>>+ else
> >>>+ { /* Parent will skip this parallel itself. */ }
> >>
> >>Here too - actually no need to have an empty else at all.
> >
> >I wanted somewhere clear for the comment to go. (Actually, I think this
> >is the one the compiler warns about -- empty dangling else).
>
> Don't recall such a warning, but that doesn't mean it isn't there. About the
> comment, it could either go just after the if, or above it, along the lines
> of
There is a warning for
if (cond);
but not for
if (cond)
;
or
if (cond)
/* comment */ ;
which is the style used in various places throughout the compiler.
> /* We handle cases X, Y, Z here. If none of them apply, then
> the parent will skip this parallel itself. */
>
> In this particular loop you could also use continue; for the empty if
> conditions.
Jakub
