Hello, This patch migrates the MIPS backend to the new vector reduction optabs.
No new regressions, ok to apply? Thanks, Simon gcc/ChangeLog: * config/mips/loongson.md (vec_loongson_extract_lo_<mode>): New, extract low part to scalar. (reduc_uplus_<mode>): Remove. (reduc_plus_scal_<mode>): Rename from reduc_splus_<mode>, Use vec loongson_extract_lo_<mode>. (reduc_smax_scal_<mode>, reduc_smin_scal_<mode>): Rename from reduc_smax_<mode>, reduc_smax_<mode>, fix constraints, use vec loongson_extract_lo_<mode>. (reduc_umax_scal_<mode>, reduc_umin_scal_<mode>): Rename, change constraints. Index: config/mips/loongson.md =================================================================== --- config/mips/loongson.md (revision 228282) +++ config/mips/loongson.md (working copy) @@ -852,58 +852,66 @@ "dsrl\t%0,%1,%2" [(set_attr "type" "fcvt")]) -(define_expand "reduc_uplus_<mode>" - [(match_operand:VWH 0 "register_operand" "") - (match_operand:VWH 1 "register_operand" "")] +(define_insn "vec_loongson_extract_lo_<mode>" + [(set (match_operand:<V_inner> 0 "register_operand" "=r") + (vec_select:<V_inner> + (match_operand:VWHB 1 "register_operand" "f") + (parallel [(const_int 0)])))] "TARGET_HARD_FLOAT && TARGET_LOONGSON_VECTORS" -{ - mips_expand_vec_reduc (operands[0], operands[1], gen_add<mode>3); - DONE; -}) + "mfc1\t%0,%1" + [(set_attr "type" "mfc")]) -; ??? Given that we're not describing a widening reduction, we should -; not have separate optabs for signed and unsigned. -(define_expand "reduc_splus_<mode>" - [(match_operand:VWHB 0 "register_operand" "") +(define_expand "reduc_plus_scal_<mode>" + [(match_operand:<V_inner> 0 "register_operand" "") (match_operand:VWHB 1 "register_operand" "")] "TARGET_HARD_FLOAT && TARGET_LOONGSON_VECTORS" { - emit_insn (gen_reduc_uplus_<mode>(operands[0], operands[1])); + rtx tmp = gen_reg_rtx (GET_MODE (operands[1])); + mips_expand_vec_reduc (tmp, operands[1], gen_add<mode>3); + emit_insn ( gen_vec_loongson_extract_lo_<mode> (operands[0], tmp)); DONE; }) -(define_expand "reduc_smax_<mode>" - [(match_operand:VWHB 0 "register_operand" "") - (match_operand:VWHB 1 "register_operand" "")] +(define_expand "reduc_smax_scal_<mode>" + [(match_operand:HI 0 "register_operand" "") + (match_operand:VH 1 "register_operand" "")] "TARGET_HARD_FLOAT && TARGET_LOONGSON_VECTORS" { - mips_expand_vec_reduc (operands[0], operands[1], gen_smax<mode>3); + rtx tmp = gen_reg_rtx (GET_MODE (operands[1])); + mips_expand_vec_reduc (tmp, operands[1], gen_smax<mode>3); + emit_insn ( gen_vec_loongson_extract_lo_<mode> (operands[0], tmp)); DONE; }) -(define_expand "reduc_smin_<mode>" - [(match_operand:VWHB 0 "register_operand" "") - (match_operand:VWHB 1 "register_operand" "")] +(define_expand "reduc_smin_scal_<mode>" + [(match_operand:HI 0 "register_operand" "") + (match_operand:VH 1 "register_operand" "")] "TARGET_HARD_FLOAT && TARGET_LOONGSON_VECTORS" { - mips_expand_vec_reduc (operands[0], operands[1], gen_smin<mode>3); + rtx tmp = gen_reg_rtx (GET_MODE (operands[1])); + mips_expand_vec_reduc (tmp, operands[1], gen_smin<mode>3); + emit_insn ( gen_vec_loongson_extract_lo_<mode> (operands[0], tmp)); DONE; }) -(define_expand "reduc_umax_<mode>" - [(match_operand:VB 0 "register_operand" "") +(define_expand "reduc_umax_scal_<mode>" + [(match_operand:QI 0 "register_operand" "") (match_operand:VB 1 "register_operand" "")] "TARGET_HARD_FLOAT && TARGET_LOONGSON_VECTORS" { - mips_expand_vec_reduc (operands[0], operands[1], gen_umax<mode>3); + rtx tmp = gen_reg_rtx (GET_MODE (operands[1])); + mips_expand_vec_reduc (tmp, operands[1], gen_umax<mode>3); + emit_insn ( gen_vec_loongson_extract_lo_<mode> (operands[0], tmp)); DONE; }) -(define_expand "reduc_umin_<mode>" - [(match_operand:VB 0 "register_operand" "") +(define_expand "reduc_umin_scal_<mode>" + [(match_operand:QI 0 "register_operand" "") (match_operand:VB 1 "register_operand" "")] "TARGET_HARD_FLOAT && TARGET_LOONGSON_VECTORS" { - mips_expand_vec_reduc (operands[0], operands[1], gen_umin<mode>3); + rtx tmp = gen_reg_rtx (GET_MODE (operands[1])); + mips_expand_vec_reduc (tmp, operands[1], gen_umin<mode>3); + emit_insn ( gen_vec_loongson_extract_lo_<mode> (operands[0], tmp)); DONE; })