On Tue, Sep 29, 2015 at 06:04:55PM +0200, Marc Glisse wrote: > On Tue, 29 Sep 2015, Marek Polacek wrote: > > >This fixes missing warning for the attached testcase. In such a case, > >we must use the expansion point location. I didn't simply add > > loc = expansion_point_location_if_in_system_header (loc); > >as might be seen elsewhere in the codebase because we pass LOC down to > >convert_for_assignment where many of the warnings are issued and I was > >nervous about passing a different location there. > > I assume this means that the other missing warning from > http://stackoverflow.com/questions/32732281/no-warning-when-returning-null-with-gcc > (same code but change the return type from void to int) > is not fixed at the same time?
Nope, I wasn't aware of that one :(. Maybe we want the loc = expansion_point_location_if_in_system_header (loc); line after all... Marek