On 09/28/2015 11:44 AM, Dominik Vogt wrote:
On Fri, Sep 25, 2015 at 03:33:56PM +0200, Bernd Schmidt wrote:
On 09/24/2015 03:48 PM, Dominik Vogt wrote:
Hm, I wonder whether wrapping all these section switches in
assemble_start/end_function in ".machine" pseudoops (that's what
we need the hooks for; similar to .arch for ix86) has any real
effect.

I don't think I follow what you're trying to say here?

I mean, it's more or less random whether switching to and from the
function's section ends up inside the new .machine and
.machinemode directives (if the section needs to be switched for
this function) or outside (if the assembler code had already
switched to the correct section earlier).  I assume that .machine
and .machinemode have no effect on the section switching, but I'm
not completely sure (alignment?).

(@Andreas + Uli: Do you know of any effect this would have on
s390?)

Still not really following since I don't know anything about s390 and its directives. In case you're trying to figure out whether it's possible to use the existing macros, please continue doing so. If you reach the conclusion that you really do need the new hooks, your patch is ok. However, you probably should add a sentence or two to the documentation to specify ordering wrt other parts of the header of a function.


Bernd

Reply via email to