On 09/11/2015 03:28 PM, Tom de Vries wrote:

This patch adds handling of a DEFPARAMENUM macro, which is similar to
the DEFPARAM macro, but allows the values to be named.

So the definition of param parloop-schedule becomes:
...
DEFPARAMENUM PARAM_PARLOOPS_SCHEDULE,
              "parloops-schedule",
              "Schedule type of omp schedule for loops parallelized by "
              "parloops (static, dynamic, guided, auto, runtime)",
              0, 0, 4, "static", "dynamic", "guided", "auto", "runtime")

So in principle I like this, but there's one oddity:

+  switch (schedule_type)
+    {
+    case 0:
+      OMP_CLAUSE_SCHEDULE_KIND (t) = OMP_CLAUSE_SCHEDULE_STATIC;
+      break;

The code using the param is using integers rather than enum values. Can that be fixed?

...
[ I'll repost the original patch containing this update. ]

I'll let Jakub and/or Richard handle the rest of that. I'm curious why this would be a param rather than a -f option.


Bernd

Reply via email to