On Wed, Aug 26, 2015 at 4:14 AM, Rainer Orth
<r...@cebitec.uni-bielefeld.de> wrote:
> Solaris 12 changes the stat_[amc]tim members of struct stat from
> timestruc_t to timespec_t for XPG7 compatiblity, thus breaking the libgo
> build.  The following patch checks for this change and uses the common
> stat_atim.go if appropriate.
>
> Btw., I noticed that go/os/stat_atim.go and stat_dragonfly.go are identical;
> no idea why that would be useful.
>
> Bootstrapped without regressions on i386-pc-solaris2.1[12] and
> sparc-sun-solaris2.1[12].
>
> I had to regenerate aclocal.m4 since for some reason it had been built
> with automake 1.11.1 instead of the common 1.11.6, thus inhibiting
> Makefile.in regeneration.
>
> Ok for mainline now and the gcc 5 branch after some soak time?
>
>         Rainer
>
>
> 2015-02-10  Rainer Orth  <r...@cebitec.uni-bielefeld.de>
>
>         * configure.ac (have_stat_timespec): Check for timespec_t st_atim
>         in <sys/stat.h>.
>         (HAVE_STAT_TIMESPEC): New conditional.
>         * configure: Regenerate.
>         * Makefile.am [LIBGO_IS_SOLARIS && HAVE_STAT_TIMESPEC]
>         (go_os_stat_file): Use go/os/stat_atim.go.
>         * aclocal.m4: Regenerate.
>         * Makefile.in: Regenerate.

Thanks.  Committed to mainline.

Sorry for the slow review.

This is fine to commit to GCC 5 branch.

stat_atim.go is a gccgo-specific file.  stat_dragonfly.go came in from
the master Go repository.  Just another thing to straighten out some
time.

Ian

Reply via email to