On Tue, 1 Sep 2015, Martin Sebor wrote: > I also noticed uses of DECL_LANG_FLAG_4 in the definitions of > what appear to be C-specific macros in c-family/c-common.h, > and then uses of the same macro in definitions of a C++-specific > macro in cp/cp-tree.h.
That seems like a bug waiting to happen, given that there is nothing obviously C-specific about the users in common code of those macros. > In this light it seems to me that leaving the test for the flag > as it was would be both in keeping with existing practice and > preferable to introducing the hook. The existing practice you found was of use of DECL_LANG_FLAG_* in defining macros. Not direct use in C files, which is clearly much worse. I suppose there's the option of defining the macro in c-common.h, but defining it in a way that includes an assertion that it's never evaluated for C++. -- Joseph S. Myers jos...@codesourcery.com
