> Ah, I didn't realize that. I guess you're right, it's better to split
> the filename:linenumber to a separate line. But still, I think it's
> clearer if you keep the "in" and "at" like the current code & gdb
> does. Thus, something like
>
> #framenumber 0xADDRESS in funcname
> at filename:linenumber
Done.
> And another thing which I previously missed: You have removed the
> store_exe_path function as it's no longer used for anything. However,
> that function is part of the libgfortran ABI and is found in
> gfortran.map, so we have to keep it until we bump the so version. :(
Which is what I did, though it’s not very clear from the .diff itself. The
function is emptied but remains in libgfortran/runtime/main.c:
void
store_exe_path (const char * argv0 __attribute__ ((unused)))
{
/* This function is now useless, but is retained due to ABI compatibility.
Remove when bumping the library ABI. */
;
}
> Please also add a note to the libgfortran ABI cleanup wiki page so we
> don't forget about it.
Done.
> With these changes, Ok for trunk. Thanks a lot for working on this!
Committed as revision 227106 with the changes above.
Thanks for reviewing the patch.
FX
