Re: [PATCH testsuite, ARM] skip Wno-frame-address tests

[Kyrill Tkachov]

Hi Christian,

On 20/08/15 14:45, Christian Bruel wrote:

Hello,

2 tests from rev 226480 introduced a new failure for ARM testing -Werror
because a warning is always emitted regardless -Wframe-address is given
or not.

  From expand_builtin_frame_address:

   /* Some ports cannot access arbitrary stack frames.  */
        if (tem == NULL)
        {
          warning (0, "unsupported argument to %qD", fndecl);
          return const0_rtx;
        }

This patch just skips the test on ARM that can't access arbitrary stack
frame anyway and will always warn.

OK for trunk ? thanks,

Christian





        

no-frame-address.patch


015-08-20  Christian Bruel<christian.br...@st.com>

        * gcc.dg/Wno-frame-address.c: Skip for ARM.
        * g++.dg/Wno-frame-address.C: Ditto.

Index: gcc/testsuite/gcc.dg/Wno-frame-address.c
===================================================================
--- gcc/testsuite/gcc.dg/Wno-frame-address.c    (revision 227030)
+++ gcc/testsuite/gcc.dg/Wno-frame-address.c    (working copy)
@@ -1,4 +1,5 @@
  /* { dg-do compile } */
+/* { dg-skip-if "Cannot access arbitrary stack frames. " { arm*-*-* } { "*" } { 
"" } } */
  /* { dg-options "-Werror" } */

/* Verify that -Wframe-address is not enabled by default by enabling

Index: gcc/testsuite/g++.dg/Wno-frame-address.C
===================================================================
--- gcc/testsuite/g++.dg/Wno-frame-address.C    (revision 227030)
+++ gcc/testsuite/g++.dg/Wno-frame-address.C    (working copy)
@@ -1,4 +1,5 @@
  // { dg-do compile }
+/* { dg-skip-if "Cannot access arbitrary stack frames. " { arm*-*-* } { "*" } { 
"" } } */
  // { dg-options "-Werror" }

Use the C++-style comment here.
Otherwise looks ok to me, though if more tests like this crop we'd want a
dg-requires-effective-target check that filters out the targets that don't
implement this feature.

Kyrill

// Verify that -Wframe-address is not enabled by default by enabling