On Thu, Jul 23, 2015 at 03:03:29PM +0200, Ulrich Weigand wrote:
> Jakub Jelinek wrote:
> > On Thu, Jul 23, 2015 at 02:46:43PM +0200, Ulrich Weigand wrote:
> > > > I bet that is gone break also cross-compilers from s390* to other
> > > > targets.
> > >
> > > I think this should be fine on s390. The problem with i386 is that
> > > the driver-native.c file uses data types only defined by the i386
> > > target files (e.g. enum processor_type). But on s390, the file does
> > > not any target-specific types and should be fully portable.
> >
> > That hunk means that driver-native.o is added to EXTRA_GCC_OBJS
> > even say for s390x-*-* -> x86_64-*-* compiler. While it might compile
> > there, nothing will use it, so what is it good for?
> > i?86/x86_64 backend will certainly not reference s390_host_detect_local_cpu
> > anywhere.
>
> Oh, I agree this will not be *used*. I just wanted to point out that it
> will not *break* cross-compilers as is.
I think it would be better for consistency and sanity do what other
targets do, even if it won't break the cross-compilation.
Do you agree?
Jakub
