Hi Nathan! On Thu, 09 Jul 2015 20:25:22 -0400, Nathan Sidwell <[email protected]> wrote: > This is the patch I committed. [...]
Prompted by your recent "-O0 patch" to »[f]ix PTX worker spill/fill«, I
used the attached patch 0001-O0-libgomp-C-C-testing.patch to run all C
and C++ libgomp testing with -O0 (for Fortran, we iterate through various
kinds of optimization levels anyway). (There are no regressions of
OpenMP testing.)
For OpenACC nvptx offloading, there must still be something wrong; here's
a count of the (non-deterministic!) regressions of ten runs of the
libgomp testsuite. As private-vars-loop-worker-5.c fails most often, it
probably makes sense to look into that one first.
For avoidance of doubt, there are no such regressions if I un-apply your
patch to »[m]ove openacc vector& worker single handling to RTL«.
libgomp.oacc-c:
3: [-PASS:-]{+FAIL:+}
libgomp.oacc-c/../libgomp.oacc-c-c++-common/private-vars-local-worker-1.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
4: [-PASS:-]{+FAIL:+}
libgomp.oacc-c/../libgomp.oacc-c-c++-common/private-vars-local-worker-2.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
3: [-PASS:-]{+FAIL:+}
libgomp.oacc-c/../libgomp.oacc-c-c++-common/private-vars-local-worker-3.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
5: [-PASS:-]{+FAIL:+}
libgomp.oacc-c/../libgomp.oacc-c-c++-common/private-vars-local-worker-4.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
4: [-PASS:-]{+FAIL:+}
libgomp.oacc-c/../libgomp.oacc-c-c++-common/private-vars-local-worker-5.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
3: [-PASS:-]{+FAIL:+}
libgomp.oacc-c/../libgomp.oacc-c-c++-common/private-vars-loop-vector-1.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
2: [-PASS:-]{+FAIL:+}
libgomp.oacc-c/../libgomp.oacc-c-c++-common/private-vars-loop-vector-2.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
3: [-PASS:-]{+FAIL:+}
libgomp.oacc-c/../libgomp.oacc-c-c++-common/private-vars-loop-worker-2.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
2: [-PASS:-]{+FAIL:+}
libgomp.oacc-c/../libgomp.oacc-c-c++-common/private-vars-loop-worker-3.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
2: [-PASS:-]{+FAIL:+}
libgomp.oacc-c/../libgomp.oacc-c-c++-common/private-vars-loop-worker-4.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
8: [-PASS:-]{+FAIL:+}
libgomp.oacc-c/../libgomp.oacc-c-c++-common/private-vars-loop-worker-5.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
4: [-PASS:-]{+FAIL:+}
libgomp.oacc-c/../libgomp.oacc-c-c++-common/private-vars-loop-worker-6.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
4: [-PASS:-]{+FAIL:+}
libgomp.oacc-c/../libgomp.oacc-c-c++-common/private-vars-loop-worker-7.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
1: [-PASS:-]{+FAIL:+}
libgomp.oacc-c/../libgomp.oacc-c-c++-common/worker-partn-5.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
3: [-PASS:-]{+FAIL:+}
libgomp.oacc-c/../libgomp.oacc-c-c++-common/worker-partn-6.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
libgomp.oacc-c++:
5: [-PASS:-]{+FAIL:+}
libgomp.oacc-c++/../libgomp.oacc-c-c++-common/private-vars-local-worker-1.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
5: [-PASS:-]{+FAIL:+}
libgomp.oacc-c++/../libgomp.oacc-c-c++-common/private-vars-local-worker-2.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
4: [-PASS:-]{+FAIL:+}
libgomp.oacc-c++/../libgomp.oacc-c-c++-common/private-vars-local-worker-3.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
5: [-PASS:-]{+FAIL:+}
libgomp.oacc-c++/../libgomp.oacc-c-c++-common/private-vars-local-worker-4.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
6: [-PASS:-]{+FAIL:+}
libgomp.oacc-c++/../libgomp.oacc-c-c++-common/private-vars-local-worker-5.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
3: [-PASS:-]{+FAIL:+}
libgomp.oacc-c++/../libgomp.oacc-c-c++-common/private-vars-loop-vector-1.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
2: [-PASS:-]{+FAIL:+}
libgomp.oacc-c++/../libgomp.oacc-c-c++-common/private-vars-loop-worker-2.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
4: [-PASS:-]{+FAIL:+}
libgomp.oacc-c++/../libgomp.oacc-c-c++-common/private-vars-loop-worker-3.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
4: [-PASS:-]{+FAIL:+}
libgomp.oacc-c++/../libgomp.oacc-c-c++-common/private-vars-loop-worker-4.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
7: [-PASS:-]{+FAIL:+}
libgomp.oacc-c++/../libgomp.oacc-c-c++-common/private-vars-loop-worker-5.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
4: [-PASS:-]{+FAIL:+}
libgomp.oacc-c++/../libgomp.oacc-c-c++-common/private-vars-loop-worker-6.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
5: [-PASS:-]{+FAIL:+}
libgomp.oacc-c++/../libgomp.oacc-c-c++-common/private-vars-loop-worker-7.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
1: [-PASS:-]{+FAIL:+}
libgomp.oacc-c++/../libgomp.oacc-c-c++-common/worker-partn-6.c
-DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test
Grüße,
Thomas
From a527ce3bcb60a4dbd8feb579dd90688b33760d78 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge <[email protected]> Date: Fri, 17 Jul 2015 15:24:19 +0200 Subject: [PATCH] -O0 libgomp C, C++ testing --- libgomp/testsuite/libgomp.c++/c++.exp | 1 + libgomp/testsuite/libgomp.c/c.exp | 1 + libgomp/testsuite/libgomp.oacc-c++/c++.exp | 1 + libgomp/testsuite/libgomp.oacc-c/c.exp | 1 + 4 files changed, 4 insertions(+) diff --git a/libgomp/testsuite/libgomp.c++/c++.exp b/libgomp/testsuite/libgomp.c++/c++.exp index d6d525a..6bdb83d 100644 --- a/libgomp/testsuite/libgomp.c++/c++.exp +++ b/libgomp/testsuite/libgomp.c++/c++.exp @@ -16,6 +16,7 @@ if [info exists lang_include_flags] then { if ![info exists DEFAULT_CFLAGS] then { set DEFAULT_CFLAGS "-O2" } +set DEFAULT_CFLAGS "-O0" # Initialize dg. dg-init diff --git a/libgomp/testsuite/libgomp.c/c.exp b/libgomp/testsuite/libgomp.c/c.exp index 25f347b..f89377f 100644 --- a/libgomp/testsuite/libgomp.c/c.exp +++ b/libgomp/testsuite/libgomp.c/c.exp @@ -16,6 +16,7 @@ load_gcc_lib gcc-dg.exp if ![info exists DEFAULT_CFLAGS] then { set DEFAULT_CFLAGS "-O2" } +set DEFAULT_CFLAGS "-O0" # Initialize dg. dg-init diff --git a/libgomp/testsuite/libgomp.oacc-c++/c++.exp b/libgomp/testsuite/libgomp.oacc-c++/c++.exp index 7309f78..4dba472 100644 --- a/libgomp/testsuite/libgomp.oacc-c++/c++.exp +++ b/libgomp/testsuite/libgomp.oacc-c++/c++.exp @@ -18,6 +18,7 @@ if [info exists lang_include_flags] then { if ![info exists DEFAULT_CFLAGS] then { set DEFAULT_CFLAGS "-O2" } +set DEFAULT_CFLAGS "-O0" # Initialize dg. dg-init diff --git a/libgomp/testsuite/libgomp.oacc-c/c.exp b/libgomp/testsuite/libgomp.oacc-c/c.exp index 60be15d..80b4635 100644 --- a/libgomp/testsuite/libgomp.oacc-c/c.exp +++ b/libgomp/testsuite/libgomp.oacc-c/c.exp @@ -18,6 +18,7 @@ load_gcc_lib gcc-dg.exp if ![info exists DEFAULT_CFLAGS] then { set DEFAULT_CFLAGS "-O2" } +set DEFAULT_CFLAGS "-O0" # Initialize dg. dg-init -- 2.1.4
signature.asc
Description: PGP signature
