On Fri, Jul 17, 2015 at 11:44:47AM -0400, Nathan Sidwell wrote:
> On 07/17/15 10:44, Jakub Jelinek wrote:
> >On Wed, Jul 15, 2015 at 03:04:30PM -0400, Nathan Sidwell wrote:
> >>I'm almost tempted to commit as obvious. I noticed that the callers of
> >>these functions from code generated by mkoffload declare the 2nd arg as an
> >>int, because they have no visibility of the enum. I thought it wise to make
> >>the definitions match.
> >
> >I think it doesn't really matter that much, such an enum on all targets we
> >care
> >about is passed the same way as int.
> >
> >But if you think it is important, I don't really care either way.
>
> Having been bitten by fshort-enums on ARM, I like to be careful :)
That is an ABI changing option, though perhaps somebody might build libgomp
for that ABI. Ok then.
Jakub
