> On Jul 15, 2015, at 8:58 AM, Mikael Morin <mikael.mo...@sfr.fr> wrote: > > The patch itself looks good to me. > A ChangeLog entry should be provided with it. > The test is missing the usual dejagnu pattern matching directives to > check the generated code. > Do you have commit rights?
Hi Mikael, Thanks for the quick review. I know Alessandro is not a reviewer. Assuming commit rights go with review rights, I’m guessing he doesn’t have commit rights. I’ll let him confirm. If he doesn’t have commit rights, could you commit it for us after he adds the derange pattern-matching directives? Alternatively, if it’s easy, please feel free to add the directives and commit. Your fast response is very helpful to us. The co_reduce collective is the final feature that we hope to finish before taking a snapshot of OpenCoarrays and designating it as our 1.0.0 release. :) Toward that end, could this fix also be applied to the GCC 5 branch? Soon after posting a tar ball of OpenCoarrays 1.0.0 on the web, Alessandro will submit a Portfile to the Macports developers that will enable OS X users to install OpenCoarrays 1.0.0 for use with GCC 5. It would be great for Macports users to have co_reduce when the next GCC 5 update releases. Damian
