Re: [PATCH, gomp4] Propagate independent clause for OpenACC kernels pass

[Thomas Schwinge]

Hi Chung-Lin!

On Tue, 14 Jul 2015 13:46:04 +0800, Chung-Lin Tang <clt...@codesourcery.com> 
wrote:
> this patch provides a 'bool independent' field in struct loop, which
> will be switched on by an "independent" clause in a #pragma acc loop 
> directive.

Thanks!


This patch has been developed in context of OpenACC kernels constructs,
but, is there anything still to be done regarding OpenACC parallel
constructs?  That is, are we currently *using* the "independent yes/no"
information appropriately for these?


>         * omp-low.c (struct omp_region): Add 'int kind' and
>         'bool independent' fields.

> --- omp-low.c (revision 225758)
> +++ omp-low.c (working copy)
> @@ -136,8 +136,16 @@ struct omp_region
>    /* True if this is nested inside an OpenACC kernels construct.  */
>    bool inside_kernels_p;
>  
> +  /* Records a generic kind field.  */
> +  int kind;
> +
>    /* For an OpenACC loop, the level of parallelism requested.  */
>    int gwv_this;
> +
> +  /* For an OpenACC loop directive, true if has the 'independent' clause.  */
> +  bool independent;
> +
> +  tree broadcast_array;
>  };

I'm assuming just a patch conflict resolution hiccup; committed in
r225767:

commit 4a10c97b741bbc3d7278779337d5c0bfea8297c2
Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Tue Jul 14 09:30:02 2015 +0000

    Code cleanup
    
        gcc/
        * omp-low.c (struct omp_region): Remove broadcast_array member.
    
    ... that mistakenly reappeared in r225759, after having been removed in
    r225647.
    
    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gomp-4_0-branch@225767 
138bc75d-0d04-0410-961f-82ee72b054a4
---
 gcc/ChangeLog.gomp | 4 ++++
 gcc/omp-low.c      | 2 --
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git gcc/ChangeLog.gomp gcc/ChangeLog.gomp
index dfe0c95..d7459d0 100644
--- gcc/ChangeLog.gomp
+++ gcc/ChangeLog.gomp
@@ -1,3 +1,7 @@
+2015-07-14  Thomas Schwinge  <tho...@codesourcery.com>
+
+       * omp-low.c (struct omp_region): Remove broadcast_array member.
+
 2015-07-14  Tom de Vries  <t...@codesourcery.com>
 
        * tree-parloops.c (parallelize_loops): Use marked_independent flag in
diff --git gcc/omp-low.c gcc/omp-low.c
index fc6c7a9..0419dcd 100644
--- gcc/omp-low.c
+++ gcc/omp-low.c
@@ -144,8 +144,6 @@ struct omp_region
 
   /* For an OpenACC loop directive, true if has the 'independent' clause.  */
   bool independent;
-
-  tree broadcast_array;
 };
 
 /* Context structure.  Used to store information about each parallel


Grüße,
 Thomas

pgpzur1TWFsHn.pgp
Description: PGP signature