Hi Steven,
On Sun, 24 Jul 2011, Steven Bosscher wrote:
Can you please create your patches with the -p option, so that it's
easier to see what function you are changing? Also, even for an RFC
patch a ChangeLog is more than just nice to have ;-)
Do you mean an entry in Changelog file in root directory? I should update
my tree to latest every time, for my patch to be valid, right?
This hunk in df-problems looks odd:
@@ -2511,9 +2535,9 @@
if (bb_index == EXIT_BLOCK)
{
unsigned regno;
- bitmap_iterator bi;
- EXECUTE_IF_SET_IN_BITMAP (df->exit_block_uses, FIRST_PSEUDO_REGISTER,
- regno, bi)
So this EXECUTE_IF_SET_IN_BITMAP starts with FIRST_PSEUDO_REGISTER
(i.e. works on pseudo registers) ...
+ hard_reg_set_iterator iter;
+ EXECUTE_IF_SET_IN_HARD_REG_SET (df->exit_block_uses,
FIRST_PSEUDO_REGISTER,
+ regno, iter)
gcc_unreachable ();
}
else
... and you change it to work only on hard registers. That code looked
like a check to verify that exit_block_uses only contains hard
registers. So you can probably just drop this check.
Thanks for reminding me this, I had indeed removed this check, I just
didn't commit to my VCS :-)
Should I resend my patch with all the suggestions you made?
Thanks,
Dimitris
