On Wed, Jul 8, 2015 at 12:07 AM, Jeff Law <l...@redhat.com> wrote: > On 07/07/2015 06:37 AM, Alan Lawrence wrote: >> >> As per https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01346.html. Fixes >> FAIL of advsimd-intrinsics vcreate.c on aarch64_be-none-elf from >> previous patch. >> >> 15_native_interpret_real.patch >> >> >> commit e2e7ca148960a82fc88128820f17e7cbd14173cb >> Author: Alan Lawrence<alan.lawre...@arm.com> >> Date: Thu Apr 9 10:54:40 2015 +0100 >> >> Fix native_interpret_real for HFmode floats on Bigendian with >> UNITS_PER_WORD>=4 >> >> (with missing space) > > OK with ChangeLog in proper form.
Err - but now offset can become negative? Shouldn't it rather error out before as it requires at least 4 bytes for big-endian? That said - the whole thing looks it doesn't expect GET_MODE_SIZE < 4 and your "fix" is just very obfuscated (if it really is a fix). So, please cleanup the thing properly instead or at least add a big fat comment. There is the magic '3' in the line following yours as well. Thanks, Richard. > jeff >
