On Fri, Jul 22, 2011 at 7:28 PM, Richard Henderson <r...@redhat.com> wrote: > On 07/22/2011 10:19 AM, Ulrich Weigand wrote: >> Richard Henderson wrote: >>> On 07/22/2011 07:42 AM, Ulrich Weigand wrote: >>>> Well, it works for me with just adding -lm to the dg-extra-ld-options. >>>> This still folds cabs to sqrt in the LTO step, and then satisfies that >>>> call via the libm routine ... If I understood your intent correctly, >>>> this should still test the same thing, shouldn't it? >>> >>> Not quite, since -lm also provides cabs. >> >> Well, yes (mine does as well). But the -O2 LTO step will still fold cabs >> to sqrt instead of pulling in the cabs from the library, at least it does >> for me. Thus the test still verifies this folding doesn't crash, which >> is what I understood it should do. Am I missing something? > > Oops, sorry. I forgot we were testing for a crash, not verifying the fold.
Of course testing for the fold makes sure we also test for the crash ... so yes, the idea was to also test for the fold. As the LTO testing harness does not support scanning dumps (sigh...) link tests are the only possibility right now. Richard. > > r~ >
