On Fri, Jul 3, 2015 at 10:37 AM, Jakub Jelinek <ja...@redhat.com> wrote: > On Fri, Jul 03, 2015 at 10:32:38AM +0200, Richard Biener wrote: >> On Thu, Jul 2, 2015 at 10:49 PM, Jakub Jelinek <ja...@redhat.com> wrote: >> > On Thu, Jul 02, 2015 at 04:47:13PM -0400, David Edelsohn wrote: >> >> I can change the patch to include it after system.h, if that is >> >> preferred. That order also works on AIX. >> > >> > If including it right after system.h works, it is preapproved. >> >> Note that after config.h is generally better (considering all the #poison >> stuff in system.h). >> >> Not using std::map but GCCs own hash_map would be prefered though. >> (otherwise at some point we'll end up including all of libstdc++ from >> system.h given host compiler weirdness and workarounds for include >> stuff - which is what system.h is for) > > Can we poison std::map and other templates we want to avoid in GCC sources, > so that people wouldn't be tempted to use it?
Won't they just include <map> before system.h then? ;) This needs to be caught by patch review I fear. Richard. > Jakub
