On Thu, Jun 25, 2015 at 10:57 PM, Jeff Law <l...@redhat.com> wrote: > On 06/25/2015 02:31 PM, Andrew MacLeod wrote: >> >> I proposed including fold-const.h into gimple.h, but didn't notice that >> its actually only needed by one inline function. Moving that function to >> gimple.c means its no longer required. >> >> 160 places need cgraph.h, so by removing this dependency, the number of >> those files which still need fold-const.h drops to 108 uses. >> The other 2 files are generally used by many of the files which include >> gimple.h, so trying to break those dependencies doesn't accomplish much. >> >> This patch is currently undergoing testing, but expect no problems . >> Assuming it bootstraps on x86_64-unknown-linux-gnu with no new >> regressions, OK for trunk? > > OK.
Well, it's also just lazy in using build_fold_addr_expr_loc because it doesn't want to spell out the all-tree.h build1_loc (gimple_location (gs), ADDR_EXPR, build_pointer_type (decl), decl); there is nothing to be simplified (setting a location here is also a waste). Richard. > Jeff
