On Mon, Jun 22, 2015 at 09:24:07AM +0200, Eric Botcazou wrote: > > * rtlanal.c (commutative_operand_precedence): Correct comments. > > * simplify-rtx.c (simplify_plus_minus_op_data_cmp): Delete forward > > declaration. Return an int. Distinguish REG,REG return from > > others. > > (struct simplify_plus_minus_op_data): Make local to function. > > (simplify_plus_minus): Rename canonicalized to not_canonical. > > Don't set not_canonical if merely sorting registers. Avoid > > packing ops if nothing changes. White space fixes. > > OK in principle, but...
Thanks for reviewing! > > Some notes: Renaming canonicalized to not_canonical better reflects > > its usage. At the time the var is set, the expression hasn't been > > canonicalized. > > I'm quite skeptical, in particular given: I'm a little surprised, but committed without the renaming. -- Alan Modra Australia Development Lab, IBM
