On 21/07/11 18:13, Steven Bosscher wrote:
On Thu, Jul 21, 2011 at 2:47 PM,<ramana.radhakrish...@linaro.org> wrote:
* tree-ssa-loop-ivopts.c (rtl.h): Include.
Please don't do this. The goal should be that GIMPLE is independent of
RTL, and almost no tree-* files include rtl.h for this reason.
Including rtl.h in tree-ssa-loop-ivopts.c is a very big step in the
wrong direction.
Maybe add a function in tree-ssa-address.c for this, or use a target hook.
Thanks for looking at this. The reason I had put this in was to avoid
the issue around ivopts not finding the declaration of
extern bool arm_autoinc_modes_ok_p (enum machine_mode, RTX_CODE);
It just seemed natural to reuse RTX_CODE to distinguish the various
pre/post inc/dec cases rather than write 8 macros that handled it in
ever so similar ways. There's probably no reason why I can't use a
private interface for that or create something in tree-ssa-address.c to
take care of this.
cheers
Ramana
