Re: [PATCH] TLC to reassoc get_rank

[Jakub Jelinek]

On Fri, May 29, 2015 at 02:41:28PM +0200, Richard Biener wrote:
> @@ -525,7 +498,11 @@ get_rank (tree e)
>        return (rank + 1);
>      }
>  
> -  /* Globals, etc,  are rank 0 */
> +  /* Constants have rank 0.  */
> +  if (is_gimple_min_invariant (e))
> +    return 0;
> +
> +  /* Constants, globals, etc., are rank 0 */
>    return 0;
>  }

This looks weird.  No reason to test is_gimple_min_invariant
if it returns 0 no matter whether it is true or false.

        Jakub