On Thu, May 14, 2015 at 10:54:07AM +0200, Jakub Jelinek wrote:
> On Thu, May 14, 2015 at 10:05:36AM +0200, Jakub Jelinek wrote:
> > On Thu, May 14, 2015 at 12:10:50AM +0200, Thomas Schwinge wrote:
> > > No doubt, looking forward to the day, when this can be reverted.
> > >
> > > libgomp/
> > > * env.c (initialize_env): Remove static attribute.
> > > * libgomp.map (INTERNAL): Export initialize_env.
> >
> > Ugh. While you achieve what you want for the remote board cases,
> > doesn't this completely break all OpenMP and OpenACC programs not built
> > as part of the testsuite, because initialize_env won't be called in that
> > case?
>
> Can't you just tweak *.exp files so that if dg-set-target-env-var is used
> or some forced env var is added to the same list through other means,
> you invoke on the remove side env VAR1=val1 VAR2=val2 program arguments
> instead of program arguments ?
Talking about the libgomp testsuite, can we rename the
libgomp/testsuite/libgomp-oacc-*/*.exp files to something unique?
I mean, trying to run say just the OpenMP C tests is impossible since
the OpenACC merge, because RUNTESTFLAGS=c.exp runs both OpenMP and OpenACC.
If it was say acc-c.exp, then you can choose if you want to test just
OpenACC, or just OpenMP, both, and which particular tests more accurately.
Jakub
