On Wed, May 13, 2015 at 1:58 PM, Ramana Radhakrishnan <ramana.radhakrish...@arm.com> wrote: > On 13/05/15 17:37, Ramana Radhakrishnan wrote: >> I'm not sure what's going on here and couldn't figure out what was going >> wrong in the 20 minutes I spent on it just now. >> > Bah, I must be going blind. > >> >> @@ -53,11 +57,13 @@ >> >> ARM_FUNC_START negdf2 >> ARM_FUNC_ALIAS aeabi_dneg negdf2 >> + CFI_START_FUNCTION >> >> @ flip sign bit >> eor xh, xh, #0x80000000 > > > Either the mail server you are using or the source repository you have has > replaced tabs with spaces, the eor here has a tab in the sources between eor > and xh. Thus the patch is malformed according to the sources. I suspect > that's the reason why all the other hunks are not applying.
That makes sense. I downloaded the gcc sources from the git mirror at github-- perhaps that's what's munging the patch? > Before reposting - > > 0. Please take care of the issue I mentioned in the previous email . Will do. I honestly have no idea how that semicolon ended there, since I tried a dry run of the file I sent you and it didn't complain. Perhaps I accidentally typed it in before closing the file, I don't know. > 1. Please mail the patch so created to yourself on a different account and > applying the patch you receive on pristine sources. Identify a mail server > that you can use to send emails to lists that don't munge patches in this > manner. I used git send-email through gmail when contributing to various projects such as gdb, and so far haven't had any problems like this one. > 2. Please test such a tree and ensure no regressions in a run of the GCC > testsuite. > > 3. Post the patch back to gcc-patches@gcc.gnu.org from the mail server that > doesn't munge patches in this manner. I'll review it again then. Will do. Thanks a lot!
