On Wed, May 06, 2015 at 06:18:23PM +0200, Marek Polacek wrote:
> On Wed, May 06, 2015 at 04:58:03PM +0200, Jakub Jelinek wrote:
> > Also, it would be nice to figure why gcc doesn't warn (for both meaningful
> > changes, in the first snippet I believe gcc just determines the static
> > function is noreturn and that is why it correctly doesn't warn).
> > I thought Marek has added patches for the !x == Y case recently, so it would
> > be nice to find out why we don't warn in that case.
>
> Yes, I'd expect a warning to trigger on that.
Ah, but FUNC is 0, guess we intentionally don't warn on !x == 0,
as !x == 0 is equivalent to x != 0. So it is more of a style issue, or
would become a problem if FUNC changed from 0 to some other value.
Jakub
