On May 5, 2015 11:15:11 AM GMT+02:00, Tom de Vries <tom_devr...@mentor.com> wrote: >Hi, > >after checking in the 'postpone expanding va_arg till pass_stdarg' >patch series, >some scans related to function f15 in gcc.dg/tree-ssa/stdarg-2.c have >started >failing. > >[ The committed patch series contained a modification of stdarg-2.c, >but that >seems to be not complete and not correct. ] > >F.i., for s390 we find at >https://gcc.gnu.org/ml/gcc-testresults/2015-05/msg00507.html: >... >FAIL: gcc.dg/tree-ssa/stdarg-2.c scan-tree-dump stdarg "f15: va_list >escapes 0, >needs to save 1 GPR units and 2 FPR units" >... > >Furthermore, at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64950#c11 >it was >noted that: >... >Unfortunately, the gcc.dg/tree-ssa/stdarg-2.c part of the patch is >wrong: the >test now FAILs on i686-unknown-linux-gnu, i686-apple-darwin, and >i386-pc-solaris >with -m64: both dumps (i.e. -m32 and -m64) contain > >m32/stdarg-2.c.084t.stdarg:f15: va_list escapes 1, needs to save all >GPR units >and all FPR units. >m64/stdarg-2.c.084t.stdarg:f15: va_list escapes 1, needs to save all >GPR units >and all FPR units. >... > >I've filed two PRs: >- PR66010 '[6 Regression] Missed optimization after inlining va_list >parameter' > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66010 >- PR66013 'Missed optimization after inlining va_list parameter, -m32 >case' > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66013 >to track these errors. > >AFAIU now from the investigations in those PRs, we can expect all f15 >scans that >check for the presence of 'va_list escapes 0' to fail. > >I'd like to commit two patches. >- The first patch undoes the modification of stdarg-2.c as committed in >the > original patch series (omitted). >- The second patch adds appropriate xfails (attached). > >OK for trunk?
OK. Thanks, Richard. >Thanks, >- Tom
