On 21 April 2015 at 15:00, Matthew Wahab <matthew.wa...@arm.com> wrote:


> 2015-05-21  Matthew Wahab  <matthew.wa...@arm.com>
>
>         * gcc/config/aarch64-protos.h (struct cpu_branch_cost): New.
>         (tune_params): Add field branch_costs.
>         (aarch64_branch_cost): Declare.
>         * gcc/config/aarch64.c (generic_branch_cost): New.
>         (generic_tunings): Set field cpu_branch_cost to generic_branch_cost.
>         (cortexa53_tunings): Likewise.
>         (cortexa57_tunings): Likewise.
>         (thunderx_tunings): Likewise.
>         (xgene1_tunings): Likewise.
>         (aarch64_branch_cost): Define.
>         * gcc/config/aarch64/aarch64.h (BRANCH_COST): Redefine.
>

+int aarch64_branch_cost (bool, bool);
+

You would never guess looking at this .h today, but long ago there was
something close to alphabetical order by function name in place.
Please lift this definition between aarch64_bitmask_imm and
aarch64_classify_symbolic_expression.

+int
+aarch64_branch_cost (bool speed_p, bool predictable_p)
+{

Add an appropriate comment before the function please.

Cheers
/Marcus

Reply via email to