On Wed, 15 Apr 2015, Jakub Jelinek wrote: > Hi! > > When ICF encounteres a GIMPLE_PREDICT (as in the testcase) or GIMPLE_NOP, > it stops looking at further statements in the bb (assumes they must be the > same), which is of course wrong. > > I'm attaching 3 versions of the patch, the first one I've > bootstrapped/regtested on x86_64-linux and i686-linux, the second one > will handle GIMPLE_PREDICT just as (fixed) GIMPLE_NOP handling, as Honza is > saying that at this point GIMPLE_PREDICT can be ignored (but we e.g. risk > when using the same function for something different that we'll not handle > GIMPLE_PREDICT right), the third one is the most minimal one (but I'm afraid > the lack of GIMPLE_EH_DISPATCH region checking might cause wrong-code). > > Ok for trunk (which version) and 5.1 (which version)?
Ok for trunk and 5.1, version without GIMPLE_PREDICT handling. Let's iterate on that separately. Thanks, Richard.
