On Mon, Apr 13, 2015 at 12:54 AM, Jerry DeLisle <jvdeli...@charter.net> wrote: > Hi all, > > The attached patch fixes this bug. It also eliminates non-freed memory > whenever > a format error occurs. Particular important when the user has use IOSTAT > and generate_error does not exit, but returns to continue program execution. > > Regression tested on x86-64 and tested with -fsanitize=address and valgrind > on a number of existing test cases. Changelog is fairly clear I think. > > OK for trunk?
Instead of xmalloc + memcpy + null-terminating, please use fc_strdup (or fc_strdup_notrim if you want to retain trailing spaces) in order to create a heap-allocated null-terminated copy of a non-null-terminated string. WIth that change, Ok for trunk and affected branches. Since it doesn't seem to be über-critical, I suggest you wait with backporting to the 5.x branch until after the imminent release of 5.1 (if I understand the new numbering scheme correctly). Thanks. -- Janne Blomqvist
