Jeff Law <l...@redhat.com> writes:
> On 03/30/2015 08:00 AM, Ilya Enkovich wrote:
>> Hi,
>>
>> Currently check_effective_target_mpx doesn't check libs availability for
>> non Linux targets but tests require them. This patch modifies test to
>> requre wrappers library to link. I suppose it should fix failing tests
>> on Solaris and other non-Linux systems. Patch also replaces alloca calls
>> with __builtin_alloca calls. Have no machine to test it though (Linux
>> testing is OK). Any help with testing? Does it look OK?
>>
>> Thanks,
>> Ilya
>> --
>> 2015-03-30 Ilya Enkovich <ilya.enkov...@intel.com>
>>
>> PR target/65602
>> * gcc.target/i386/mpx/alloca-1-lbv.c (mpx_test): Use
>> __builtin_alloca instead of alloca.
>> * gcc.target/i386/mpx/alloca-1-nov.c (mpx_test): Likewise.
>> * gcc.target/i386/mpx/alloca-1-ubv.c (mpx_test): Likewise.
>> * lib/mpx-dg.exp (check_effective_target_mpx): Add wrapper
>> check.
> Seems reasonable to me, given it's all MPX bits, you can self-approve. You
> might ping Rainer Orth to see if he can test on x86 Solaris or something
> similar.
I originally reported the bug and did test the patch over the weekend:
the Solaris/x86 testsuite failures are gone, so that part is fine. I
couldn't of course test the alloca -> __builtin_alloca change since the
tests aren't built at all.
I don't have a baseline for Linux/x86_64 without --enable-libmpx (the
default) to compare against, but see in the gcc.log file that the mpx
tests aren't run in that config due to missing -lmpx -lmpxwrappers.
I'd suggest (though this is stage1 material) to split the mpx tests into
compile (requiring an assembler with mpx support) and link/run
(also requiring the runtime libs) tests to extend test coverage.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
