> On Mon, Mar 30, 2015 at 07:06:39PM +0200, Jan Hubicka wrote: > > > On Mon, Mar 30, 2015 at 05:02:57 +0200, Jan Hubicka wrote: > > > > * lto-symtab.c (lto_symtab_merge_decls_2): Silence warnings on > > > > artificial decls. > > > > > > Shouldn't this patch fix libgomp.c++/target-3.C in an offloading-enabled > > > configuration? It still fails... > > > > > > libgomp/testsuite/libgomp.c++/../libgomp.c/target-2.c:27:13: warning: > > > type 'struct .omp_data_s.7' violates one definition rule [-Wodr] > > > #pragma omp parallel for reduction(+:s) > > > ^ > > > #pragma omp parallel for reduction(+:s) > > > ^ > > > double b[3 * x], c[3 * x], d[3 * x], e[3 * x]; > > > ^ > > > double b[3 * x], c[3 * x], d[3 * x], e[3 * x]; > > > ^ > > > > No, that is an different warning. Why those types are different? Is this a > > full warning output? > > .omp_data_s.7 is a name of a really unnamed struct (DECL_NAMELESS) and also > DECL_ARTIFICIAL, contains compiler generated fields and should never be > checked for ODR violations. > > I wonder if you have any DECL_ARTIFICIAL structs you want to warn on, if > yes, then at least ignore DECL_NAMELESS ones.
Jason probably knows better, but I think only real C++ types comply the One Defintion Type and should be merged. Anything we create artifically in compiler is probably not covered by this. Honza > > Jakub
