2015-03-27 18:23 GMT+03:00 Jan Hubicka <hubi...@ucw.cz>: > Hi, > this patch fixes bug in symtab_node::verify_symtab_nodes pointed out by Ilya. > The loop checking that there all comdats are linked by same_comdat_group was > completely bogus. In addition it checked also external symbols that are > currently not kept in groups. This bug was in mainline for months but > apparently bounds checking is first code producing interesting comdat groups > to > trigger it. > > Ilya, can you please mind comitting the testcase? I am not quite sure where > bounds checking should go offhand. > > Also concerning linking the comdat groups, currently all non-DECL_EXTERNAL > symbols > are linked and all !DECL_EXTERNAL symbols are non-linked. Bounds checking > should > follow this scheme. It may be cleaner to keep links for DECL_EXTERNAL, but > lets > deffer that for next stage1.
I'll send a corresponding fix in a checker with a testcase. Please let me know when you introduce comdat links for external symbols to keep the checker in sync. Thanks, Ilya > > Bootstrapped/regtested x86_64-linux. Committed. > > Honza >
